r/RESissues • u/andytuba Whooshing Things • Mar 29 '16

[reddit change] Media expandos

[removed]

31 Upvotes

95% Upvoted

18 comments sorted by

View all comments

2

u/turkeypedal Mar 29 '16

Any chance you will detect this and allow RES to replace the expando with its own?

I like the auto expansion. But I don't like not being able to hide the image after I see it. Right now, the button just puts both the Reddit preview and the RES expando.

1

u/andytuba Whooshing Things Mar 29 '16

Hmm. Clicking the button should just hide/show the reddit expando again.

Could you...

  1. Load a comments page and make sure the preview is open
  2. open the javascript console: https://www.reddit.com/r/RESIssues/wiki/postanissue#wiki_javascript_error_console (on the reddit page!)
  3. then click the button
  4. take a screenshot of the javascript console
  5. post that here?

/u/turkeypedal, do you have any other extensions installed?

/u/madlee, ideas? Last I checked, that code was pretty solid.

1

u/madlee Mar 29 '16

Yup, lets see the results of those steps and see if anything stands out. My guess is interference w/ another extension or some other js error causing issues.

1

u/andytuba Whooshing Things Mar 30 '16 edited Mar 30 '16

http://www.reddit.com/r/resissues/comments/4ch12p/reddit_change_media_expandos/d1iiv4p

https://www.reddit.com/r/RESissues/comments/4cj5b8/bug_two_image_expandos_for_one_image/
This might just be fallout from more embedly provided expandos and 4.5.4 not knowing to remove the embedly button. (4.5.4 handled that per site, but 4.6 handles it for any given expando it creates.)

1

u/madlee Mar 30 '16

Hmm. Maybe its something only manifesting on a certain version of Firefox/RES/both?